Skip to content

feat: split out docs/react routes from shared MdxRoute file#1222

Open
jderochervlk wants to merge 1 commit intomasterfrom
vlk/split-out-docs-react
Open

feat: split out docs/react routes from shared MdxRoute file#1222
jderochervlk wants to merge 1 commit intomasterfrom
vlk/split-out-docs-react

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

@jderochervlk jderochervlk commented Apr 3, 2026

  • Create DocsReactRoute.res/.resi for /docs/react/* pages, following the same pattern as DocsManualRoute with React-specific sidebar categories (Overview, Main Concepts, Hooks & State Management, Guides) and breadcrumbs (Docs > rescript-react)
  • Register docsReactRoutes in app/routes.res via MdxFile.scanPaths and filter docs/react paths out of the legacy mdxRoutes
  • Fix inconsistent comparator in Mdx.sortSection: items with an order field now always sort before items without one, and items without order preserve their relative position (was _ => -1.0, now handles all four cases explicitly)

Note

This work was done with AI assistance

- Create DocsReactRoute.res/.resi for /docs/react/* pages, following the
  same pattern as MdxRoute with React-specific sidebar categories
  (Overview, Main Concepts, Hooks & State Management, Guides) and
  breadcrumbs (Docs > rescript-react)
- Register docsReactRoutes in app/routes.res via MdxFile.scanPaths and
  filter docs/react paths out of the legacy mdxRoutes
- Fix inconsistent comparator in Mdx.sortSection: items with an order
  field now always sort before items without one, and items without order
  preserve their relative position
@jderochervlk jderochervlk changed the base branch from vlk/split-out-docs-manual to master April 9, 2026 13:47
@jderochervlk jderochervlk force-pushed the vlk/split-out-docs-react branch from 5bbdac3 to 1e11df4 Compare April 9, 2026 13:48
@jderochervlk jderochervlk marked this pull request as ready for review April 9, 2026 13:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Cloudflare deployment

Deployement ID: 98d5829d-7084-4813-8b5b-63ad31d7e932
Deployment Environment: preview

⛅️ wrangler 4.63.0 (update available 4.81.0)
─────────────────────────────────────────────
✨ Compiled Worker successfully
Uploading... (7162/7661)
Uploading... (7329/7661)
Uploading... (7495/7661)
Uploading... (7661/7661)
✨ Success! Uploaded 499 files (7162 already uploaded) (5.21 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://98d5829d.rescript-lang.pages.dev
✨ Deployment alias URL: https://vlk-split-out-docs-react.rescript-lang.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant